On Tue, Jun 30, 2015 at 05:07:09PM +0800, James Liao wrote: > Hi Heiko, > > There are 4 clocks which are derived from clk_null directly in current > topckgen implementation: > > clkph_mck_o, dpi_ck, usb_syspll_125m, hdmitx_dig_cts > > Our designer mentioned 2 things about external clocks: > > 1. These 4 clocks come from analog macro, not from PLL, nor from > external clocks directly. Ok, this means there actually are clocks. We can't control these clock and they have some known or unknown rate. This makes them fixed clocks. Just specify them in the device tree and you are done. Give them reasonable names and the rate if you know it, 0 otherwise. The problem is not that you use fixed clocks for non software controllable clocks of unknwown rates, but that you try to use a single clock for all of them and name it 'dummy' or 'null'. Name it dpi_ck { compatible = "fixed-clock"; rate = <0>; /* unknown, generated by some Analog block */ }; Technically it's the same, but it sounds much more professional and like you know what you are doing ;) Sascha -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html