Re: [PATCH RFC 0/4] PL08x DT bindings and LPC18xx DMA support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




Hi Linus,

On 29 June 2015 at 12:53, Linus Walleij <linus.walleij@xxxxxxxxxx> wrote:
> On Sun, Jun 14, 2015 at 1:22 PM, Joachim Eastwood <manabian@xxxxxxxxx> wrote:
>
>> This patch set aims to add support for DMA on the NXP LPC18xx/43xx
>> (Cortex-M3/M4) platform. The platform has a PL080 controller with a
>> mux in front of the DMA request lines. This setup is quite common
>> and can be found on most other, if not all, NXP LPC devices.
>
> Nice!
>
>>  - remove channel sub-nodes from driver and dt doc.
>
> Why? It was a good approach for the Nomadik. Well I'll look
> how you do it for NXP, I guess it makes total sense for you.

Since the bus specifier (AHB1 / AHB2) property has been moved into the
DMA cell, I don't see a reason to keep channel sub-nodes stuff.

And I also agree with Arnd's other comments on the subject here:
https://www.marc.info/?l=linux-arm-kernel&m=141088461506806&w=2
(see at the bottom)

Summary:
* No other driver does this.
* Removing it make the driver a bit simpler.


regards,
Joachim Eastwood
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]
  Powered by Linux