Just cosmetic comments. > added device tree support to gpio-generic driver - Please use the present tense in your commit subject - Please prefix the subject with a word describing which area your patch is related to, in this case "gpio: " So, your patch subject can be improved as "gpio: add device tree support to gpio-generic driver" -- Best Regards Masahiro Yamada -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html