Re: [linux-nfc] [PATCH v3 0/2] Marvell NFC NCI UART driver and DT configuration

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On Thu, Jun 11, 2015 at 4:44 PM, Samuel Ortiz <sameo@xxxxxxxxxxxxxxx> wrote:
> Hi Vincent,
>
> On Thu, Jun 11, 2015 at 02:00:18PM +0200, Vincent Cuissard wrote:
>> Hi,
>>
>> Please find patches that add platform data configuration, DT bindings,
>> and UART driver for nfcmrvl NFC NCI driver.
>>
>> Br,
>> Vincent
>>
>> Vincent Cuissard (2):
>>   NFC: nfcmrvl: add platform_data and DT configuration
>>   NFC: nfcmrvl: add UART driver
> Both patches applied to nfc-next, thanks a lot.

This binding needs some work still. I just noticed you applied it a
few hours before I replied.

Primarily, this is one function of a combo chip. If the NFC functions
are completely independent from the other functions, then the binding
like this is probably okay. But I would expect there are some
inter-dependencies such as clock, reset line, or regulators. We should
be reviewing an 8887 binding as a whole including WiFi and BT. There's
a similar discussion happening for BT on Broadcom chips.

Rob

>
> Cheers,
> Samuel.
> --
> To unsubscribe from this list: send the line "unsubscribe devicetree" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]
  Powered by Linux