> -----Original Message----- > From: linux-input-owner@xxxxxxxxxxxxxxx [mailto:linux-input-owner@xxxxxxxxxxxxxxx] On Behalf Of Dmitry Torokhov > Sent: 09 June, 2015 20:58 > To: Tirdea, Irina > Cc: Bastien Nocera; Mark Rutland; linux-input@xxxxxxxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; Rob > Herring; Pawel Moll; Ian Campbell; Kumar Gala; Purdila, Octavian > Subject: Re: [PATCH v2 4/8] input: goodix: reset device at init > > Hi Irina, > > On Mon, Jun 08, 2015 at 05:37:49PM +0300, Irina Tirdea wrote: > > +static int goodix_get_gpio_config(struct goodix_ts_data *ts) > > +{ > > + struct device *dev; > > + struct gpio_desc *gpiod; > > + int ret; > > + > > + if (!ts->client) > > + return -EINVAL; > > + dev = &ts->client->dev; > > + > > + /* Get interrupt GPIO pin number */ > > + gpiod = devm_gpiod_get(dev, GOODIX_GPIO_INT_NAME, GPIOD_IN); > > + if (IS_ERR(gpiod)) { > > + ret = PTR_ERR(gpiod); > > + dev_err(dev, "Failed to get %s GPIO: %d\n", > > + GOODIX_GPIO_INT_NAME, ret); > > You need to handle -EPROBE_DEFER (suppress error) and especially -ENOENT error > codes, otherwise, as Bastien mentioned, you will break existing DTS. > Yes, I will handle the -EPROBE_DEFER and -ENOENT for devices that might not have these gpio pins connected or declared in ACPI/DTS. Since the following patches depend on these pins, I will bypass the functionality for these devices (suspend/resume, esd, writing config will not be available if gpio pins are not found). Thanks, Irina > Thanks. > > -- > Dmitry > -- > To unsubscribe from this list: send the line "unsubscribe linux-input" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
