On Mon, 22 Jun 2015, Opensource [Adam Thomson] wrote: > On June 19, 2015 17:48, Paul Bolle wrote: > > > On Thu, 2015-06-18 at 17:06 +0100, Adam Thomson wrote: > > > --- /dev/null > > > +++ b/include/linux/mfd/da9150/fg.h > > > > > +/* > > > + * Function template to provide battery temperature. Should provide > > > + * 0.1 degrees C resolution return values. > > > + */ > > > +typedef int (*da9150_read_temp_t)(void *context); > > > + > > > +/* Register temp callback function */ > > > +void da9150_fg_register_temp_cb(struct power_supply *psy, > > da9150_read_temp_t cb, > > > + void *cb_context); > > > > The pedant in me noticed that this function is actually added in 3/4. So > > this chunk might be moved to 3/4, if you like to entertain pedantry like > > that, that is. (But see my remark on 3/4 too.) > > This is true, but as the header is part of MFD, I included it as part of that > patch as I thought this made more sense. I guess Lee will comment as to whether > that was correct or not. :) Glanced over this (as I still have 240 unread emails to attend to). If the question is whether to submit the prototype at the same time as the associated function, the answer is yes. -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe devicetree" in
