On 06/17/2015 06:33 PM, Rob Herring wrote: > On Wed, Jun 17, 2015 at 11:53 AM, Suman Anna <s-anna@xxxxxx> wrote: >> Define stub implementation for of_find_node_by_phandle() API >> so that users of this API can build properly even when CONFIG_OF >> is not defined. >> >> Signed-off-by: Suman Anna <s-anna@xxxxxx> > > Do you have a user for this? If not, apply it when you do. Yeah, ran into a randconfig build problem on x86 when we tried to add an API to remoteproc core [1] that used this function. regards Suman [1] http://marc.info/?l=devicetree&m=143232772426559&w=2 > > Acked-by: Rob Herring <robh@xxxxxxxxxx> > >> --- >> include/linux/of.h | 5 +++++ >> 1 file changed, 5 insertions(+) >> >> diff --git a/include/linux/of.h b/include/linux/of.h >> index ddeaae6d2083..90dfdc47ae26 100644 >> --- a/include/linux/of.h >> +++ b/include/linux/of.h >> @@ -422,6 +422,11 @@ static inline struct device_node *of_find_node_opts_by_path(const char *path, >> return NULL; >> } >> >> +static inline struct device_node *of_find_node_by_phandle(phandle handle) >> +{ >> + return NULL; >> +} >> + >> static inline struct device_node *of_get_parent(const struct device_node *node) >> { >> return NULL; >> -- >> 2.4.1 >> -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html