On Tue, Jun 16, 2015 at 03:29:25PM -0700, Stephen Boyd wrote: > On 05/21/2015 09:43 AM, Srinivas Kandagatla wrote: > > + /* if it's not end on byte boundary */ > > + if ((nbits + bit_offset) % BITS_PER_BYTE) { > > + /* setup the last byte with msb bits from nvmem */ > > + rc = regmap_raw_read(nvmem->regmap, > > + cell->offset + cell->bytes - 1, &v, 1); > > + *p |= GENMASK(7, (nbits + bit_offset) % BITS_PER_BYTE) & v; > > + > > + } > > + > > + return buf; > > +} > > + > > +/** > > + * nvmem_cell_write(): Write to a given nvmem cell > > This isn't kernel doc notation. It should be like > > nvmem_cell_write - Write to a given nvmem cell Almost. Should be: nvmem_cell_write() - Write to a given nvmem cell Sascha -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html