Hi Timur On 12 June 2015 at 11:57, Timur Tabi <timur@xxxxxxxxxxxxxx> wrote: > fu.wei@xxxxxxxxxx wrote: >> >> + if (timeout <= gwdt->max_wor_timeout) >> + writel_relaxed(timeout * gwdt->clk, >> + gwdt->control_base + SBSA_GWDT_WOR); >> + else >> + writel_relaxed(gwdt->max_wor_timeout * gwdt->clk, >> + gwdt->control_base + SBSA_GWDT_WOR); > > > You pre-calculate the maximum timeout possible already, so why do you need > the if-statement? Have took Guenter's suggestion on this. > > Frankly, your non-pretimeout driver is almost identical to mine, which was > posted weeks ago. At this point, you're really just copying my driver but > putting your name on it. Everyone can see how this driver become to this one gradually. For non-pretimeout, if there is not pretimeout variable, I can only use timeout to config both of them. This is definitely not the copy of yours(check yours again, you never programme WCV, and from the comment from you , you didn't believe driver can do that. you use panic because of my patch), and I posted my patchset(with pretimeout) to linaro-acpi list before you posted yours to linux mailing list. And I always focus on mine. Let people judge from all these patchset, I don't want to argue with you on this any more. > > > -- > Sent by an employee of the Qualcomm Innovation Center, Inc. > The Qualcomm Innovation Center, Inc. is a member of the > Code Aurora Forum, hosted by The Linux Foundation. -- Best regards, Fu Wei Software Engineer Red Hat Software (Beijing) Co.,Ltd.Shanghai Branch Ph: +86 21 61221326(direct) Ph: +86 186 2020 4684 (mobile) Room 1512, Regus One Corporate Avenue,Level 15, One Corporate Avenue,222 Hubin Road,Huangpu District, Shanghai,China 200021 -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
