On Thu, Jun 11, 2015 at 8:13 PM, Rob Herring <robherring2@xxxxxxxxx> wrote: > On Thu, Jun 11, 2015 at 7:37 PM, Stephen Boyd <sboyd@xxxxxxxxxxxxxx> wrote: >> Add support for over current protection (OCP), pin control >> selection, soft start and soft start strength, auto-mode, input >> current limiting, and pull down. >> >> Cc: <devicetree@xxxxxxxxxxxxxxx> >> Signed-off-by: Stephen Boyd <sboyd@xxxxxxxxxxxxxx> >> --- >> >> Changes from v1: >> * New patch split from original SPMI regulator driver >> >> .../bindings/regulator/qcom,spmi-regulator.txt | 62 +++++ >> drivers/regulator/qcom_spmi-regulator.c | 298 ++++++++++++++++++++- >> 2 files changed, 358 insertions(+), 2 deletions(-) >> >> diff --git a/Documentation/devicetree/bindings/regulator/qcom,spmi-regulator.txt b/Documentation/devicetree/bindings/regulator/qcom,spmi-regulator.txt >> index 75b4604bad07..ab01a152e930 100644 >> --- a/Documentation/devicetree/bindings/regulator/qcom,spmi-regulator.txt >> +++ b/Documentation/devicetree/bindings/regulator/qcom,spmi-regulator.txt >> @@ -99,6 +99,68 @@ see regulator.txt - with additional custom properties described below: >> soft start are active all the time. 0 = Set initial mode to >> low power mode (LPM). >> >> +- qcom,auto-mode-enable: > > Auto regulator modes are fairly common. Can't we have a common property here? > I went with a similar set of booleans for mode selection in the initial rpm driver for family A, but Kumar objected to this. So there I ended up with "qcom,force-mode" - taking an enum - instead (see mfd/qcom-rpm.txt). It would be nice if the various regulator drivers have similar bindings... >> + Usage: optional >> + Value type: <u32> > > This can be bool. Unless we want to have a mode property with "auto" > being one possible value. > >> + Description: 1 = Enable automatic hardware selection of regulator >> + mode (HPM vs LPM); not available on boost type >> + regulators. 0 = Disable auto mode selection. >> + Regards, Bjorn -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
