Re: [PATCH v2] w1: masters: omap_hdq: Add support for 1-wire mode

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




Hi

25.05.2015, 08:15, "Vignesh R" <vigneshr@xxxxxx>:
>>  HDQ mode remains unchanged.
>>
>>  Signed-off-by: Vignesh R <vigneshr@xxxxxx>

I have no experience with omap_hdq platform, but there are quite a few questions
related to IO - you never check whether write was successful or read returned actually
valid data, is it ok? I mean is it correct to assume that read can not return 0xff for example
and it is a sign that something is wrong, or this can not happen?

As for me, I have no objection, but this patch must go via omap tree imo.
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]
  Powered by Linux