On Mon, 2015-06-08 at 15:43 -0700, David Miller wrote:
> From: Sergei Shtylyov <sergei.shtylyov@xxxxxxxxxxxxxxxxxx>
> Date: Tue, 09 Jun 2015 01:41:12 +0300
>
> > On 06/09/2015 01:19 AM, David Miller wrote:
> >
> >> It's completely implemented in software, you don't need to do anything
> >> other than properly invoke napi_gro_receive().
> >
> > Not even set NETIF_F_GRO?
>
> Yes, you have to set that by default for it to go. Thankfully this is
> also "in software" ;-)
More precisely, drivers do not have to care about this flag.
They only have to call napi_gro_receive().
core networking sets GRO flag by default in register_netdevice() for all
network devices.
#define NETIF_F_SOFT_FEATURES (NETIF_F_GSO | NETIF_F_GRO)
vi +6512 net/core/dev.c
/* Transfer changeable features to wanted_features and enable
* software offloads (GSO and GRO).
*/
dev->hw_features |= NETIF_F_SOFT_FEATURES;
dev->features |= NETIF_F_SOFT_FEATURES;
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
