On Thu, 4 Jun 2015 20:57:32 +1000 (AEST) , Michael Ellerman <mpe@xxxxxxxxxxxxxx> wrote: > On Thu, 2015-04-06 at 09:34:41 UTC, Geert Uytterhoeven wrote: > > "IS_ENABLED(PPC_PSERIES)" always evaluates to false, as IS_ENABLED() is > > supposed to be used with the full Kconfig symbol name, including the > > "CONFIG_" prefix. > > > > Add the missing "CONFIG_" prefix to fix this. > > > > Fixes: a25095d451ece23b ("of: Move dynamic node fixups out of powerpc and into common code") > > Signed-off-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx> > > --- > > > Did this bug cause any breakage? > > If yes, the fix should go to stable (for v3.17 and later). > > Yikes. Not that I've heard of. But it's reasonably new so possibly it's not hit > distros that folks tend to run on those machines. > > I'm also not clear how it would break, it could be subtle and we've not noticed. > > Nathan might have more of an idea (on CC). > > On my machine here everything that has an ibm,phandle also has a linux,phandle, > so we wouldn't hit that code path. But I'm not sure how representative that box > is. > > cheers Still, an obvious bug. I've picked it up and marked for stable. g. -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html