On Tue, Jun 2, 2015 at 6:45 AM, Linus Walleij <linus.walleij@xxxxxxxxxx> wrote: > On Fri, May 29, 2015 at 4:14 AM, Gregory Fong <gregory.0xf0@xxxxxxxxx> wrote: > >> Several drivers (e.g. gpio-keys) allow for GPIOs to be configured as >> wakeup sources, and this GPIO controller supports that through a >> separate interrupt path. >> >> The de-facto standard DT property "wakeup-source" is checked, since >> that indicates whether the GPIO controller hardware can wake. Uses >> the IRQCHIP_MASK_ON_SUSPEND irq_chip flag because UPG GIO doesn't have >> any of its own wakeup source configuration. >> >> Signed-off-by: Gregory Fong <gregory.0xf0@xxxxxxxxx> > > (...) >> + if (enable) >> + enable_irq_wake(priv->parent_wake_irq); >> + else >> + disable_irq_wake(priv->parent_wake_irq); >> + return 0; > > No error handling? If the code assumes these calls will > always succeed, atleast write that in a comment. Will add error handling. Thanks, Gregory -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
