Re: [PATCH v4 2/4] ARM: shmobile: add r8a7793 minimal SoC device tree

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On Mon, Jun 1, 2015 at 11:37 AM, Geert Uytterhoeven
<geert@xxxxxxxxxxxxxx> wrote:
> Hi Ulrich,
>
> On Thu, May 28, 2015 at 5:15 PM, Ulrich Hecht
> <ulrich.hecht+renesas@xxxxxxxxx> wrote:
>> Minimal r8a7793 device tree including one CPU core, interrupt controllers,
>> timers, two serial ports, and the Ethernet controller, plus the required
>> clock descriptions.
>
>> --- /dev/null
>> +++ b/arch/arm/boot/dts/r8a7793.dtsi
>> @@ -0,0 +1,368 @@
>
>> +       cpus {
>> +               #address-cells = <1>;
>> +               #size-cells = <0>;
>> +
>> +               cpu0: cpu@0 {
>> +                       device_type = "cpu";
>> +                       compatible = "arm,cortex-a15";
>> +                       enable-method = "renesas,r8a7793";
>
> I don't think we need the enable-method in a minimal tree, do we?

Nope.

>> +       clocks {
[...]
>> +       };
>
> I don't see the rationele behind keeping some mstp clocks, and others not,
> for a miminal dtsi.

Some clocks are required by the minimal set of devices, and I did not
want to take apart individual MSTPs because IMO it's error-prone and
does not provide any real benefit.

CU
Uli
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]
  Powered by Linux