Hi Sebastian, Am 27.05.2015 um 15:51 schrieb Sebastian Reichel: > Hi Stefan, > > On Wed, May 27, 2015 at 09:12:48AM +0200, Stefan Wahren wrote: >> Am 23.05.2015 um 19:41 schrieb Sebastian Reichel: >>> On Wed, Apr 29, 2015 at 10:32:24PM +0000, Stefan Wahren wrote: >>>> This patch adds a minimal driver for the Freescale i.MX23, i.MX28 >>>> power subsystem. It's required to trigger the probing of the underlying >>>> drivers like on-chip regulators. >>> I'm not sure what you need the power supply class for. I see only >>> one property (ac connected), which is constant. Maybe just drop >>> the power supply stuff? >> those SoCs could be powered by 3 different sources: >> - 5V wall >> - USB >> - battery >> >> I choose the first one as a base, because it's the simplest one. >> Unfortunately i don't have the time to implement all of them. > From what I can see the driver does not implement the 5V wall > charger handling. It simply assumes, that the 5V wall charger > is there. the driver consists of multiple files in the mxs sub directory. I linked to the main file to reduce search effort. The battery handling incl. charging should be implemented in ddi_power_battery.c >From my understanding it's not possible to determine where the 5V exactly come from (either 5V wall plug or USB). The driver simply uses the USB PHY state. > > While you can skip implementation of battery connection check > you should make sure, that AC is actually connected. Do you refer to the right state of property POWER_SUPPLY_PROP_ONLINE or driver probing? Stefan -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
