My bad. This is ISC license. MODULE_LICENSE should actually be "Dual BSD/GPL". Same license is used in other places in the kernel like drivers/net/wireless/ath/ath10k/pci.c. I'll post a v2. Thanks, Mathieu -----Original Message----- From: Paul Bolle [mailto:pebolle@xxxxxxxxxx] Sent: Wednesday, May 27, 2015 12:04 AM To: Mathieu Olivari Cc: robh+dt@xxxxxxxxxx; pawel.moll@xxxxxxx; mark.rutland@xxxxxxx; ijc+devicetree@xxxxxxxxxxxxxx; galak@xxxxxxxxxxxxxx; mturquette@xxxxxxxxxx; sboyd@xxxxxxxxxxxxxx; peppe.cavallaro@xxxxxx; agross@xxxxxxxxxxxxxx; joshc@xxxxxxxxxxxxxx; architt@xxxxxxxxxxxxxx; georgi.djakov@xxxxxxxxxx; wsa@xxxxxxxxxxxxx; rnayak@xxxxxxxxxxxxxx; davem@xxxxxxxxxxxxx; vbridger@xxxxxxxxxxxxxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; linux-clk@xxxxxxxxxxxxxxx; netdev@xxxxxxxxxxxxxxx Subject: Re: [PATCH 4/5] stmmac: add ipq806x glue layer Just a nit: a license mismatch. On Tue, 2015-05-26 at 12:27 -0700, Mathieu Olivari wrote: > --- /dev/null > +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-ipq806x.c > + * Permission to use, copy, modify, and/or distribute this software > + for any > + * purpose with or without fee is hereby granted, provided that the > + above > + * copyright notice and this permission notice appear in all copies. > + * > + * THE SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS ALL > + WARRANTIES > + * WITH REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED WARRANTIES OF > + * MERCHANTABILITY AND FITNESS. IN NO EVENT SHALL THE AUTHOR BE > + LIABLE FOR > + * ANY SPECIAL, DIRECT, INDIRECT, OR CONSEQUENTIAL DAMAGES OR ANY > + DAMAGES > + * WHATSOEVER RESULTING FROM LOSS OF USE, DATA OR PROFITS, WHETHER IN > + AN > + * ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING > + OUT OF > + * OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE. I have no idea which license this is. > +MODULE_LICENSE("GPL"); But I do know that it's not GPL v2 or later (see include/linux/module.h). Paul Bolle -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
