On 08/05/15 14:27, Jyri Sarha wrote: > For all that I know this should be good for taking. > > Changes since v4 > * Rebased on top linux-4.1-rc2 > * Drop "drm/tilcdc: Decrement refcount of ep-node from of_graph_get_next_..." > * Make connector_funcs const in struct tilcdc_drm_private because > struct drm_connector's helper_private has been qualified as const in > linux-4.1 > * Check if a subcomponent has already triggered the unloading. > - Fixes an oops if the external encoder is unloaded first and tilcdc after > * Add comment to explain hijacking of external drm connectors helper hijacking > > Changes since v3 version of the patch-set: > * drm/tilcdc: Add support for external tda998x encoder > - Hijack external connectors helper functions > - Remove select of nonexistent DRM_TILCDC_INIT in tilcdc Kconfig > - Correct author mail address to tilcdc_exteral.h > * drm/tilcdc: Add DRM_TILCDC_SLAVE_COMPAT for ti,tilcdc,slave binding > - Add a header file for tilcdc_slave_compat.dtb symbol declarations > > Changes since v2 version of the patch-set: > - use obj-y in Makefle for tilcdc subdir in: > "drm/tilcdc: Force building of DRM_TILCDC_SLAVE_COMPAT" > - move to last: > "drm/tilcdc: Decrement refcount of ep-node from of_graph_get_next_endpoint" > > Changes since first version of the patch-set: > - Rename DRM_TILCDC_INIT to DRM_TILCDC_SLAVE_COMPAT and make it visible > - Add separate: > drm/tilcdc: Decrement refcount of ep-node from of_graph_get_next_endpoint > - Reduce info-level spam > - Use component_master_add_with_match() > - Be more explicit about tda998x being the only supported external encoder > > Remove tilcdc slave support and connect to tda998x trough its > component DRM API. For dtb backward compatibility the code creates at > boot time a DT overlay based on the earlier binding. The overlay > conforms to the new graph based binding. > > The "drm/tilcdc: Decrement refcount of ep-node from > of_graph_get_next_endpoint" should probably not be merged. The "of: > Decrement refcount of previous endpoint in of_graph_get_next_endpoint" > is eventually going to be merged and before that leaking of two > of-node refcount increments each time the module is loaded is not that > serious. The of-nodes live forever anyway. > > The merge of the dts patch can be delayed until the next merger > window, when the other patches are already in. The > DRM_TILCDC_SLAVE_COMPAT should keep the bbb HDMI operational until > then. > > The first patch is just a bugfix and can be applied or dropped > independently. This works fine for me, and looks ok. There is a minor problem in the Kconfig, where you define DRM_TILCDC_SLAVE_COMPAT before DRM_TILCDC. That causes menuconfig to show the items wrongly. Tomi
Attachment:
signature.asc
Description: OpenPGP digital signature
