On Tue, 2015-05-26 at 17:06 +0530, Sanchayan Maity wrote: > --- /dev/null > +++ b/drivers/soc/fsl/Kconfig > +config SOC_VF610 > + bool "SoC bus device for the Freescale Vybrid platform" > + select SOC_BUS > + help > + Include support for the SoC bus on the Freescale Vybrid platform > + providing some sysfs information about the module variant. > \ No newline at end of file (That review comment is courtesy of git.) > --- /dev/null > +++ b/drivers/soc/fsl/Makefile > +obj-$(CONFIG_SOC_VF610) += soc-vf610.o > --- /dev/null > +++ b/drivers/soc/fsl/soc-vf610.c > +MODULE_DEVICE_TABLE(of, vf610_soc_bus_match); > +module_platform_driver(vf610_soc_driver); (The series starting at https://lkml.org/lkml/2015/5/10/131 would allow to use builtin_platform_driver() for built-in only code.) > +MODULE_DESCRIPTION("Freescale VF610 SoC bus driver"); > +MODULE_LICENSE("GPL v2"); I think soc-vf610.o can only be built-in. But its code contains a few module specific macros. Was it perhaps intended for SOC_VF610 to be tristate? Paul Bolle -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
