On Mon, May 25, 2015 at 05:39:13PM +0200, Gregory CLEMENT wrote:
> Hi Boris, Arnaud,
>
> On 22/05/2015 15:34, Boris Brezillon wrote:
> > From: Arnaud Ebalard <arno@xxxxxxxxxxxx>
> >
> > Add crypto related nodes to kirkwood.dtsi.
>
> Here you use a new compatible string but with an old binding
> to let the user chose between the old and the new driver. Am I right?
I thought we had settled on the user choosing by module load/ which driver is
compiled in? The DT should be describing the hardware, not which driver the
user chooses to use.
thx,
Jason.
> > Signed-off-by: Arnaud Ebalard <arno@xxxxxxxxxxxx>
> > Signed-off-by: Boris Brezillon <boris.brezillon@xxxxxxxxxxxxxxxxxx>
> > ---
> > arch/arm/boot/dts/kirkwood.dtsi | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/arch/arm/boot/dts/kirkwood.dtsi b/arch/arm/boot/dts/kirkwood.dtsi
> > index 464f09a..1700b2b 100644
> > --- a/arch/arm/boot/dts/kirkwood.dtsi
> > +++ b/arch/arm/boot/dts/kirkwood.dtsi
> > @@ -41,7 +41,7 @@
> > pcie-io-aperture = <0xf2000000 0x100000>; /* 1 MiB I/O space */
> >
> > cesa: crypto@0301 {
> > - compatible = "marvell,orion-crypto";
> > + compatible = "marvell,kirkwood-crypto";
> > reg = <MBUS_ID(0xf0, 0x01) 0x30000 0x10000>,
> > <MBUS_ID(0x03, 0x01) 0 0x800>;
> > reg-names = "regs", "sram";
> >
>
>
> --
> Gregory Clement, Free Electrons
> Kernel, drivers, real-time and embedded Linux
> development, consulting, training and support.
> http://free-electrons.com
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
