Hi Boris, Arnaud, On 22/05/2015 15:34, Boris Brezillon wrote: > From: Arnaud Ebalard <arno@xxxxxxxxxxxx> > > Add crypto related nodes in armada-370.dtsi. > > Signed-off-by: Arnaud Ebalard <arno@xxxxxxxxxxxx> > Signed-off-by: Boris Brezillon <boris.brezillon@xxxxxxxxxxxxxxxxxx> > --- > arch/arm/boot/dts/armada-370.dtsi | 20 ++++++++++++++++++++ > 1 file changed, 20 insertions(+) > > diff --git a/arch/arm/boot/dts/armada-370.dtsi b/arch/arm/boot/dts/armada-370.dtsi > index 00b50db5..1255318 100644 > --- a/arch/arm/boot/dts/armada-370.dtsi > +++ b/arch/arm/boot/dts/armada-370.dtsi > @@ -307,6 +307,26 @@ > dmacap,memset; > }; > }; > + > + crypto@90000 { > + compatible = "marvell,armada-370-crypto"; > + reg = <0x90000 0x10000>; > + reg-names = "regs"; > + interrupts = <48>; There is no clocks property. After a quick look on the datasheet, indeed I didn't find any clock which match the CESA. In this case you should update the binding documentation by adding that the clock is optional for armada-370-crypto. But for this patch: Acked-by: Gregory CLEMENT <gregory.clement@xxxxxxxxxxxxxxxxxx> And as for the other one I will wait for that the driver will be merged before applying it. Thanks, Gregory > + marvell,crypto-srams = <&crypto_sram>; > + marvell,crypto-sram-size = <0x800>; > + status = "okay"; > + }; > + }; > + > + crypto_sram: sa-sram { > + compatible = "mmio-sram"; > + reg = <MBUS_ID(0x09, 0x01) 0 0x800>; > + reg-names = "sram"; > + #address-cells = <1>; > + #size-cells = <1>; > + ranges = <0 MBUS_ID(0x09, 0x01) 0 0x800>; > + status = "okay"; > }; > }; > }; > -- Gregory Clement, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html