Hi Arnd Thanks :-) On 22 May 2015 at 23:24, Arnd Bergmann <arnd@xxxxxxxx> wrote: > On Friday 22 May 2015 23:18:21 Hanjun Guo wrote: >> On 2015年05月22日 23:01, Guenter Roeck wrote: >> > On Fri, May 22, 2015 at 04:55:04PM +0200, Arnd Bergmann wrote: >> >> On Friday 22 May 2015 22:50:30 Hanjun Guo wrote: >> >>>> diff --git a/drivers/watchdog/Kconfig b/drivers/watchdog/Kconfig >> >>>> index e5e7c55..25a0df1 100644 >> >>>> --- a/drivers/watchdog/Kconfig >> >>>> +++ b/drivers/watchdog/Kconfig >> >>>> @@ -152,6 +152,18 @@ config ARM_SP805_WATCHDOG >> >>>> ARM Primecell SP805 Watchdog timer. This will reboot your system when >> >>>> the timeout is reached. >> >>>> >> >>>> +config ARM_SBSA_WATCHDOG >> >>>> + tristate "ARM SBSA Generic Watchdog" >> >>>> + depends on ARM || ARM64 || COMPILE_TEST >> >>> >> >>> SBSA is for ARMv8-A based (64-bit) servers, no need to depends on ARM, >> >>> and why we depends on COMPILE_TEST? >> >>> >> >> >> >> I think it's a reasonable assumption that someone will sooner or later >> >> put that hardware into an ARM32 machine, or run a 32-bit kernel on >> >> a chip that has it. >> >> >> >> While SBSA requires this watchdog device, nothing prevents SoC >> >> manufacturers from using the same design in something that is not >> >> a server. >> >> From this point of view, I agree that SBSA watchdog design may used >> in other ARM SoCs in the future, but how about add it back when this >> kind of hardware showing up? > > If it builds on ARM32, I'd rather leave the option in, it doesn't hurt. yes, I am agree with you. Reason: (1)Although the SBSA spec is all about ARMv8, but in "5 APPENDIX A: GENERIC WATCHDOG", nothing says SBSA watchdog is only for ARM64. (2)SBSA watchdog should work with arch_timer which has be used on ARMv7 and ARMv8. (3)there are ARM32 servers in the market(although there is not SBSA watchdog in them) (4) all the regs of SBSA watchdog are 32Bit, this IP core can be use in ARM32(I don't know the implementation detail of this IP core, but from the spec , I don't see "It can't be used on ARM32") (5)we don't need to change any code, any line.(yes, it doesn't hurt) So maybe we can keep this The only problem we face is : there is not a ARM32 hardware or a simulator of ARM32 has SBSA watchdog on it. and we don't know if ARM will put this IP core in any Soc in the future :-( Maybe because this IP core is new. > >> > Tricky, though. Since teh driver uses arm specific clock functions, >> > I don't think this can compile on a non-arm machine. >> >> Since it depends on ARM64/ARM, we can temporary release from that now > > We have to drop the '|| COMPILE_TEST' though as a result, or fix the > driver to look up the clock in DT and call 'clk_get_rate'. > > That will break the ACPI case, but ACPI could use platform_data to > pass the clock rate into the driver, to make it independent of > low-level APIs. for this problem , we not only need to get "rate" but also need to get timestamp. So for now , we need to use some ARM specific code in arm_arch_timer.c, unless those interface is integrated into clk framework(or we have make a patch for if) any suggestion or thought? Great thanks for your review :-) > > Arnd > _______________________________________________ > Linaro-acpi mailing list > Linaro-acpi@xxxxxxxxxxxxxxxx > https://lists.linaro.org/mailman/listinfo/linaro-acpi -- Best regards, Fu Wei Software Engineer Red Hat Software (Beijing) Co.,Ltd.Shanghai Branch Ph: +86 21 61221326(direct) Ph: +86 186 2020 4684 (mobile) Room 1512, Regus One Corporate Avenue,Level 15, One Corporate Avenue,222 Hubin Road,Huangpu District, Shanghai,China 200021 -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
