Hi Guenter. Sorry for my poor English . let me explain this : On 22 May 2015 at 21:23, Guenter Roeck <linux@xxxxxxxxxxxx> wrote: > On 05/22/2015 03:46 AM, Fu Wei wrote: >> >> Hi Timo, >> > [ ... ] > >> So I am still trying to improve pretimeout support :-) > > > Is there anything still missing from it ? > >> If I can make pretimeout merged, may be you can try pretimeout to >> implement early_timeout_sec function? > > > Not sure how one would or even could do that. > > Do you mean "implement early_pretimeout_sec", by any chance ? I mean: using pretimeout to implement the function you want, instead of early_pretimeout_sec Hope I say the right word this time :-) > >> It is up to the maintainers, I will try my best. >> > > Please don't make the pretimeout concept more complicated than necessary. > > The smaller the patch, the more likely it is to get accepted. > The more you change, the more difficult it is for the maintainer to, > for example, back-port later bug fixes into earlier kernel releases > when needed. This is why it is, for example, better to keep the > existing watchdog_init_timeout() function instead of just replacing > it with watchdog_init_timeouts(). > > Try to put yourself into the maintainer's perspective: If you were > the maintainer, would you rather accept a patch or patch set which > maintains the existing API and doesn't require any changes to existing > drivers, or would you accept one that changes, say, some function > or variable names and will require manual back-ports later on if > there is a bug fix ? Would you rather accept a patch that adds 50 lines > of code, or one that changes another 100+ lines and rearranges everything > along the line ? > > Thanks, > Guenter > -- Best regards, Fu Wei Software Engineer Red Hat Software (Beijing) Co.,Ltd.Shanghai Branch Ph: +86 21 61221326(direct) Ph: +86 186 2020 4684 (mobile) Room 1512, Regus One Corporate Avenue,Level 15, One Corporate Avenue,222 Hubin Road,Huangpu District, Shanghai,China 200021 -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
