RE: [PATCH v3 1/2] pwm: Add device tree binding document for R-Car PWM Timer

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




Hi Geert-san,

Thank you for the review!

> Sent: Thursday, May 21, 2015 5:32 PM
> 
> Hi Shimoda-san,
> 
> On Thu, May 21, 2015 at 4:50 AM, Yoshihiro Shimoda
> <yoshihiro.shimoda.uh@xxxxxxxxxxx> wrote:
> > Add binding document for Renesas PWM Timer on R-Car SoCs.
> 
> Thanks for your patch!
> 
> > Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@xxxxxxxxxxx>
> 
> Acked-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
> with one minor nit below.

Thank you for the Acked-by.

> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/pwm/renesas,pwm-rcar.txt
> 
> > +Example: R8A7790 (R-Car H2) PWM Timer node
> > +
> > +       pwm0: pwm@e6e30000 {
> > +               compatible = "renesas,pwm-r8a7790", "renesas,pwm-rcar";
> > +               reg = <0 0xe6e30000 0 0x10>;
> 
> Length 8 is sufficient, as there are only 2 32-bit registers.

Thank you for the point. I will fix it.

Best regards,
Yoshihiro Shimoda

> > +               #pwm-cells = <2>;
> > +               clocks = <&mstp5_clks R8A7790_CLK_PWM>;
> > +               pinctrl-0 = <&pwm0_pins>;
> > +               pinctrl-names = "default";
> > +       };
> 
> Gr{oetje,eeting}s,
> 
>                         Geert
> 
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
> 
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
>                                 -- Linus Torvalds
> --
> To unsubscribe from this list: send the line "unsubscribe devicetree" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
��.n��������+%������w��{.n����z�{��ܨ}���Ơz�j:+v�����w����ޙ��&�)ߡ�a����z�ޗ���ݢj��w�f





[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]
  Powered by Linux