On Wed, May 20, 2015 at 9:22 AM, Shawn Guo <shawn.guo@xxxxxxxxxx> wrote:
> On Tue, May 19, 2015 at 09:44:46PM -0500, Zhi Li wrote:
>> On Tue, May 19, 2015 at 8:58 PM, Shawn Guo <shawnguo@xxxxxxxxxx> wrote:
>> > On Wed, May 20, 2015 at 01:04:35AM +0800, Frank.Li@xxxxxxxxxxxxx wrote:
>> >> From: Frank Li <Frank.Li@xxxxxxxxxxxxx>
>> >>
>> >> Change from v1 to v2
>> >> - Change simple-bus to simple-mfd
>> >> - RTC remove lock.
>> >> - RTC remove comments "These register offsets are relative to LP (Low Power) range"
>> >> - power off, remove extra space
>> >>
>> >> SNVS is MPF module.
>> >> include rtc, power off, ON/OFF power key
>> >>
>> >> arm: imx: power-off: change to syscon to access register
>> >> rtc: arm: imx: snvs: change use syscon to access register
>> >> Above two patch change existed power-off and rtc use syscon
>> >>
>> >> Document: dt: fsl: snvs: change support syscon
>> >> arm: dts: imx: update snvs to use syscon access register
>> >> Update dt file and document
>> >>
>> >> input: keyboard: imx: add snvs power key driver
>> >> document: devicetree: input: imx: i.mx snvs power device tree bindings
>> >> arm: dts: imx6sx: enable snvs power key
>> >> Added on/off key driver
>> >>
>> >> Frank Li (6):
>> >> arm: imx: power-off: change to syscon to access register
>> >> rtc: arm: imx: snvs: change use syscon to access register
>> >> Document: dt: fsl: snvs: change support syscon
>> >> arm: dts: imx: update snvs to use syscon access register
>> >> document: devicetree: input: imx: i.mx snvs power device tree bindings
>> >> arm: dts: imx6sx: enable snvs power key
>> >
>> > So, the series will break existing DTBs for RTC and poweroff, right?
>> > If this is unavoidable, should we at least have some warning messages
>> > telling users about his breakage?
>>
>> How to do that?
>> Just added it commit message or need runtime warning?
>
> runtime, so that users can know why their installed DTBs break with the
> new kernel.
+ snvs_np = of_get_parent(pdev->dev.of_node);
+ if (!snvs_np)
+ return -ENODEV;
+
+ data->snvs = syscon_node_to_regmap(snvs_np);
+ of_node_put(snvs_np);
+
+ if (!data->snvs) {
+ pr_err("Can't snvs syscon\n");
+ return -ENODEV;
+ }
How about change error message to " Can't snvs syscon, probably use
old dts file"?
>
> Shawn
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
