2015-05-16 9:58 GMT+02:00 Yingjoe Chen <yingjoe.chen@xxxxxxxxxxxx>: > Spurious mtk timer interrupt is noticed at boot and cause kernel > crash. It seems if GPT is enabled, it will latch irq status even > when its IRQ is disabled. When irq is enabled afterward, we see > spurious interrupt. > Change init flow to only enable GPT_CLK_SRC at mtk_timer_init. > > Signed-off-by: Yingjoe Chen <yingjoe.chen@xxxxxxxxxxxx> > --- > drivers/clocksource/mtk_timer.c | 15 ++++++++++----- > 1 file changed, 10 insertions(+), 5 deletions(-) > > diff --git a/drivers/clocksource/mtk_timer.c b/drivers/clocksource/mtk_timer.c > index 68ab423..91206f9 100644 > --- a/drivers/clocksource/mtk_timer.c > +++ b/drivers/clocksource/mtk_timer.c > @@ -157,8 +157,11 @@ static void mtk_timer_global_reset(struct mtk_clock_event_device *evt) > } > > static void > -mtk_timer_setup(struct mtk_clock_event_device *evt, u8 timer, u8 option) > +mtk_timer_setup(struct mtk_clock_event_device *evt, > + u8 timer, u8 option, u8 enable) Nicer would be: static void mtk_timer_setup(struct mtk_clock_event_device *evt, u8 timer, u8 option, u8 enable) Apart from that parameter enable should be of type bool. Thanks, Matthias -- motzblog.wordpress.com -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html