2015-05-20 13:05 GMT+09:00 Alexandre Courbot <gnurou@xxxxxxxxx>: > On Tue, May 19, 2015 at 8:51 PM, Krzysztof Kozlowski > <k.kozlowski.k@xxxxxxxxx> wrote: >> Usage of labels instead of full paths reduces possible mistakes when >> overriding nodes. >> >> Signed-off-by: Krzysztof Kozlowski <k.kozlowski.k@xxxxxxxxx> > > Indentation seems to be off by one tab in the added code (hence the > huge size of this patch ; most lines should not change), can you > check? It is correct. This change in indentation is an effect of moving nodes out of first bracket ("\ {"). That is the convention. It us up to you guys if this is worth the effort. For exynos we use label-convention and now I am converting old DTS to it. I think the label-convention is less error-prone when extending or overriding nodes. Also it removes duplicated addresses. Best regards, Krzysztof -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html