On Wed, May 20, 2015 at 01:24:32AM +0000, Yoshihiro Shimoda wrote:
> Hi Morimoto-san,
>
> > Sent: Wednesday, May 20, 2015 9:06 AM
> >
> > Hi Shimoda-san
> >
> > I guess previous Geert's opinion about compatible is...
> >
> > > +Required Properties:
> > > +- compatible: should be one of the following.
> > > + - "renesas,pwm-r8a7778": for R-Car M1A
> > > + - "renesas,pwm-r8a7779": for R-Car H1
> > > + - "renesas,pwm-r8a7790": for R-Car H2
> > > + - "renesas,pwm-r8a7791": for R-Car M2-W
> > > + - "renesas,pwm-r8a7794": for R-Car E2
> > (snip)
> > > +static const struct of_device_id rcar_pwm_of_table[] = {
> > > + { .compatible = "renesas,pwm-r8a7778", },
> > > + { .compatible = "renesas,pwm-r8a7779", },
> > > + { .compatible = "renesas,pwm-r8a7790", },
> > > + { .compatible = "renesas,pwm-r8a7791", },
> > > + { .compatible = "renesas,pwm-r8a7794", },
> > > + { },
> > > +};
> >
> > - compatible: should be one of the following.
> > - "renesas,pwm-rcar": for R-Car <=
> > ... /* we need gen1 / gen2 here ? */
> > - "renesas,pwm-r8a7778": for R-Car M1A
> > - "renesas,pwm-r8a7779": for R-Car H1
> > - "renesas,pwm-r8a7790": for R-Car H2
> > - "renesas,pwm-r8a7791": for R-Car M2-W
> > - "renesas,pwm-r8a7794": for R-Car E2
> >
> > static const struct of_device_id rcar_pwm_of_table[] = {
> > { .compatible = "renesas,pwm-rcar", }, <=
> > { },
>
> Thank you for your comment.
> I understood it. If such a document and code, there is similar with the sh-sci driver.
> So, I will fix this patch set.
Does the documentation (e.g. datasheet) indicate that the PWM blocks are
the same for at least all of the R-Car SoCs that we know about?
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
