On Mon, May 04, 2015 at 06:24:10PM +0300, Stanimir Varbanov wrote: > On 05/04/2015 05:35 PM, Kishon Vijay Abraham I wrote: > > Hi, > > > > On Monday 04 May 2015 06:12 PM, Stanimir Varbanov wrote: > >> Add a PCIe PHY driver used by PCIe host controller driver > >> on Qualcomm SoCs like Snapdragon 805. > >> > >> Signed-off-by: Stanimir Varbanov <svarbanov@xxxxxxxxxx> > >> --- > >> drivers/phy/Kconfig | 9 ++ > >> drivers/phy/Makefile | 1 + > >> drivers/phy/phy-qcom-pcie.c | 291 > >> +++++++++++++++++++++++++++++++++++++++++++ > > > > Why do you need a new PHY driver for this? Why not use the existing QCOM > > PHY driver. I can see the registers used here in phy-qcom-ufs-qmp-14nm.h? > > I agree that on first glance there are similarities, but I'm not sure > does the PHYs are the same IP blocks. Or at least they are different > revisions which have too many differences. So trying to combine them > will lead to more code than now. > > Either way I will try to understand how many the differences are. Ping, where are we with this? Should I wait for something else, or are you convinced there's enough difference to warrant a new PHY driver, Kishon? Bjorn -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
