Re: [PATCH 2/2] twl4030_charger: find associated phy by more reliable means.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




Hi,

On Fri, May 08, 2015 at 11:12:05AM -0500, Felipe Balbi wrote:
> On Mon, Mar 23, 2015 at 09:52:48AM +1100, NeilBrown wrote:
> > From: NeilBrown <neilb@xxxxxxx>
> > 
> > twl4030_charger currently finds the associated phy
> > using usb_get_phy() which will return the first USB2 phy.
> > If your platform has multiple such phys (as mine does),
> > this is not reliable (and reliably fails on the GTA04).
> > 
> > Change to use devm_usb_get_phy_by_node(), having found the
> > node by looking for an appropriately named sibling in
> > device-tree.
> > 
> > This makes usb-charging dependent on correct device-tree
> > configuration.
> > 
> > Acked-by: Pavel Machek <pavel@xxxxxx>
> > Signed-off-by: NeilBrown <neilb@xxxxxxx>
> > ---
> 
> Sebastian, can I get your Acked-by here ?

Acked-By: Sebastian Reichel <sre@xxxxxxxxxx>

-- Sebastian

Attachment: signature.asc
Description: Digital signature


[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]
  Powered by Linux