Hi,
>> + edac: edac@78800000 {
>> + compatible = "apm,xgene-edac";
>> + #address-cells = <2>;
>> + #size-cells = <2>;
>> + reg = <0x0 0x78800000 0x0 0x100>;
>
> This seens a 'ranges' property to make the address resolution
> work. An empty property should be fine.
>
>> + interrupts = <0x0 0x20 0x4>,
>> + <0x0 0x21 0x4>,
>> + <0x0 0x27 0x4>;
>> +
>> + edacmc0: edacmc0@7e800000 {
>> + compatible = "apm,xgene-edac-mc";
>> + regmap-csw = <&csw>;
>> + regmap-mcba = <&mcba>;
>> + regmap-mcbb = <&mcbb>;
>> + reg = <0x0 0x7e800000 0x0 0x1000>;
>> + };
>> +
>> + edacpmd0: edacpmd0@7c000000 {
>> + compatible = "apm,xgene-edac-pmd";
>> + regmap-efuse = <&efuse>;
>> + reg = <0x0 0x7c000000 0x0 0x200000>;
>> + };
>
> Why do you have labels for each one? If nothing references
> these nodes, just remove the labels.
>
> Regarding the names, remove the numbers for the nodes that are
> uniquely identified by the register location, e.g. replace
> edacmc0@7e800000 with edacmc@7e800000.
I will remove all label and get rip of the number before @.
>
> If you have multiple edac-mc devices, would they point to the
> same syscon nodes, or different ones for each? If they are the
> same, just move the references to the main node.
They all reference the same one. I will move it up one level.
-Loc
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
