Ping? On Thu, Apr 23, 2015 at 3:58 PM, Ricardo Ribalda Delgado <ricardo.ribalda@xxxxxxxxx> wrote: > of_platform_depopulate can lead to a kernel error when calling release_resource() > > The reason is that it is trying to release a resource that was not allocated > via insert_resource() > > of_platform_depopulate() > of_platform_device_destroy() > platform_device_unregister(platform_device *pdev) > platform_device_del(platform_device *pdev) > for (i = 0; i < pdev->num_resources; i++) > release_resource() > > of_platform_populate() > ... > of_device_alloc() > pdev = platform_device_alloc() > # set pdev->resource, similar to platform_device_add_resources() > of_device_add(platform_device *pdev) > # similar to platform_device_add(), but note there's no > # insert_resource() in this path > device_add(&pdev->dev) > > On this patchset: > > base/platform has been fixed for an hypothetical condition where parent is > set but the platform is neither MEM or IO. > > Then platform_device_alloc has been modified so it supports of and amba > devices. > > Finally of_device_add has been modified to use platform_device_add(). > > v1: https://lkml.org/lkml/2015/4/20/435 > > v2: From: Bjorn Helgaas <bhelgaas@xxxxxxxxxx> > -Fix caller, not callee > > https://lkml.org/lkml/2015/4/21/99 > https://lkml.org/lkml/2015/4/21/100 > > v3: From: Rob Herring <robherring2@xxxxxxxxx> > - Modify plaform_device_alloc to support of and ambda devices > > https://lkml.org/lkml/2015/4/22/369 > https://lkml.org/lkml/2015/4/22/370 > https://lkml.org/lkml/2015/4/22/371 > https://lkml.org/lkml/2015/4/22/374 > https://lkml.org/lkml/2015/4/22/373 > > v4: From: Bjorn Helgaas <bhelgaas@xxxxxxxxxx> > -Remove WARN() patch > -Show conflicting resources > -Code Style > -Fix descriptions > > From: Rob Herring <robherring2@xxxxxxxxx> > -Fix descriptions > > Ricardo Ribalda Delgado (4): > base/platform: Only insert MEM and IO resources > base/platform: Continue on insert_resource() error > of/platform: Use platform_device interface > base/platform: Remove code duplication > > drivers/base/platform.c | 84 ++++++++++++++++++++++++------------------------- > drivers/of/platform.c | 3 +- > 2 files changed, 43 insertions(+), 44 deletions(-) > > -- > 2.1.4 > -- Ricardo Ribalda -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
