Hi Krzysztof, Yep these values are wrong. These cooling-max-level and cooling-min-level values come with cpufreq operating-points Which is not present in the dts right now. So I will update for now with this value. cooling-min-level = <0>; cooling-max-level = <7>; -Anand Moon On 13 May 2015 at 15:42, Krzysztof Kozlowski <k.kozlowski@xxxxxxxxxxx> wrote: > 2015-05-13 19:07 GMT+09:00 Anand Moon <linux.amoon@xxxxxxxxx>: >> On 13 May 2015 at 13:01, Krzysztof Kozlowski <k.kozlowski@xxxxxxxxxxx> wrote: >>> 2015-05-13 15:36 GMT+09:00 Anand Moon <linux.amoon@xxxxxxxxx>: >>>> update the cooling level for cpu0 to avoid following message. >>> >>> Capitalize sentence. >>> In commit subject add missing colon after "exynos5420". >>> >>>> >>>> root@odroidxu3:~# dmesg | grep ther >>> >>> This command not needed, we all know how to use dmesg and grep. >>> >>>> [ 0.241511] /thermal-zones/cpu-thermal/cooling-maps/map0: >>>> could not get #cooling-cells for /cpus/cpu@0 >>>> >>>> Tested-by: Markus Reichl <m.reichl@xxxxxxxxxxxxx> >>>> Acked-by: Lukasz Majewski <l.majewski@xxxxxxxxxxx> >>>> Signed-off-by: Anand Moon <linux.amoon@xxxxxxxxx> >>>> --- >>>> arch/arm/boot/dts/exynos5420.dtsi | 4 ++++ >>>> 1 file changed, 4 insertions(+) >>>> >>>> diff --git a/arch/arm/boot/dts/exynos5420.dtsi b/arch/arm/boot/dts/exynos5420.dtsi >>>> index 4531753..c75ed16 100644 >>>> --- a/arch/arm/boot/dts/exynos5420.dtsi >>>> +++ b/arch/arm/boot/dts/exynos5420.dtsi >>>> @@ -61,6 +61,10 @@ >>>> reg = <0x0>; >>>> clock-frequency = <1800000000>; >>>> cci-control-port = <&cci_control1>; >>>> + >>>> + cooling-min-level = <10>; >>>> + cooling-max-level = <7>; >>>> + #cooling-cells = <2>; /* min followed by max */ >>> >>> I might be missing something but I do not understand which cooling >>> levels are referenced here. In my exynos5420.dtsi file there are no >>> frequencies for cpu0 node. Could you help me understand this? >>> >>> Best regards, >>> Krzysztof >> >> Hi Krzysztof, >> >> http://lxr.free-electrons.com/source/Documentation/devicetree/bindings/cpufreq/cpufreq-dt.txt >> http://lxr.free-electrons.com/source/Documentation/devicetree/bindings/thermal/thermal.txt#L201 >> >> These two documents provide the description on cooling-min-level and >> cooling-max-level. >> >> I will correctly update the value in the next updated patch. > > I know these files and AFAIU your does not follow the documentation. > So this is why I am asking: you are referencing cooling level 7 and > 10, please show where are these cooling levels defined. -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
