Hi Krzysztof, You are correct. #cooling-cells property are required by the thermal-zone. http://lxr.free-electrons.com/source/drivers/thermal/of-thermal.c#L607 So I picked this values from earlier series of CPU frequency by Thomas. Hope this explains the changes. I will update the commit log. -Anand Moon On 13 May 2015 at 13:01, Krzysztof Kozlowski <k.kozlowski@xxxxxxxxxxx> wrote: > 2015-05-13 15:36 GMT+09:00 Anand Moon <linux.amoon@xxxxxxxxx>: >> update the cooling level for cpu0 to avoid following message. > > Capitalize sentence. > In commit subject add missing colon after "exynos5420". > >> >> root@odroidxu3:~# dmesg | grep ther > > This command not needed, we all know how to use dmesg and grep. > >> [ 0.241511] /thermal-zones/cpu-thermal/cooling-maps/map0: >> could not get #cooling-cells for /cpus/cpu@0 >> >> Tested-by: Markus Reichl <m.reichl@xxxxxxxxxxxxx> >> Acked-by: Lukasz Majewski <l.majewski@xxxxxxxxxxx> >> Signed-off-by: Anand Moon <linux.amoon@xxxxxxxxx> >> --- >> arch/arm/boot/dts/exynos5420.dtsi | 4 ++++ >> 1 file changed, 4 insertions(+) >> >> diff --git a/arch/arm/boot/dts/exynos5420.dtsi b/arch/arm/boot/dts/exynos5420.dtsi >> index 4531753..c75ed16 100644 >> --- a/arch/arm/boot/dts/exynos5420.dtsi >> +++ b/arch/arm/boot/dts/exynos5420.dtsi >> @@ -61,6 +61,10 @@ >> reg = <0x0>; >> clock-frequency = <1800000000>; >> cci-control-port = <&cci_control1>; >> + >> + cooling-min-level = <10>; >> + cooling-max-level = <7>; >> + #cooling-cells = <2>; /* min followed by max */ > > I might be missing something but I do not understand which cooling > levels are referenced here. In my exynos5420.dtsi file there are no > frequencies for cpu0 node. Could you help me understand this? > > Best regards, > Krzysztof -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
