Hello, [...] > > Or, something like this over this the function name. Perhaps exposing > > error code could be useful to the end user? If so then something like this: > > > > return dev_err_probe(&pdev->dev, err, > > "Failed to allocate MSI-X vectors, err=%d\n", err); > > dev_err_probe() should already print the err code, no need to add it. Ahh... I did a copy-paste of the code from above purely for illustration, sorry for the confusion here! > > Here and other errors where appropriate. > > I've changed dev_err() to dev_err_probe() in cases where the error code > is not evident (i.e. hardcoded) from the source. Makes sense. > Thank you so much for your review! Pleasure! Thank you for all the work here! Krzysztof
