On Thu, Jul 20, 2023 at 06:10:51PM +0100, Conor Dooley wrote: > On Thu, Jul 20, 2023 at 09:51:19PM +0800, Eric Lin wrote: > > +properties: > > + compatible: > > + items: > > + - const: sifive,pl2cache1 > > + - const: cache > > You omitted the pl2cache0 from here, that needs to come back! You'll end > up with 2 items entries. > Either way, I can't take this binding without a soc-specific compatible, > per sifive-blocks-ip-versioning.txt.. On this last point, what Nick Hu has done for the clint2 would be acceptable, adding a {} entry to disallow the compatible in isolation without requiring a soc-specific compatible for hardware that does not yet exist: https://lore.kernel.org/all/20250321083507.25298-1-nick.hu@xxxxxxxxxx/ Maybe that'll allow you to submit a v3 of this work? Cheers, Conor
Attachment:
signature.asc
Description: PGP signature