Re: [PATCH ath-next v11 00/13] wifi: ath12k: add Ath12k AHB driver support for IPQ5332

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 3/18/2025 1:30 PM, Krzysztof Kozlowski wrote:
> On Tue, Mar 18, 2025 at 02:16:26AM +0530, Raj Kumar Bhagat wrote:
>> Currently, Ath12k driver only supports WiFi devices that are based on
>> PCI bus. New Ath12k device IPQ5332 is based on AHB bus. Hence, add
>> Ath12k AHB support for IPQ5332.
>>
>> IPQ5332 is IEEE802.11be 2 GHz 2x2 Wifi device. To bring-up IPQ5332
>> device:
>> - Add hardware parameters for IPQ5332.
>> - CE register address space in IPQ5332 is separate from WCSS register
>>   space. Hence, add logic to remap CE register address.
>> - Add support for fixed QMI firmware memory for IPQ5332.
>> - Support userPD handling for WCSS secure PIL driver to enable ath12k
>>   AHB support.
>>
>> NOTE:
>> The working upstream DTS changes for this series have been posted as a
>> separate series.
>> [PATCH v2] arm64: dts: qcom: add wifi node for IPQ5332 based RDP441
>>
>> v11:
>> - Updated Kconfig for ATH12k AHB.
>> - Replaced the API devm_ioremap_wc() with devm_memremap to fix ath12k-check
>>   warning: "warning: cast removes address space '__iomem' of expression"
>> - Rebased on latest ToT.
>> - Removed tag "Reviewed-by: Vasanthakumar Thiagarajan", in the updated
>>   patch [11/13] wifi: ath12k: Power up userPD
> 
> 
> This is v11 and still sent in a way it messes with toolset:
> 
>   b4 diff -C 20250317204639.1864742-2-quic_rajkbhag@xxxxxxxxxxx
>   Grabbing thread from lore.kernel.org/all/20250317204639.1864742-2-quic_rajkbhag@xxxxxxxxxxx/t.mbox.gz
>   Checking for older revisions
>     Added from v10: 14 patches
>   ---
>   Analyzing 135 messages in the thread
>   Preparing fake-am for v11: dt-bindings: net: wireless: describe the ath12k AHB module for IPQ5332
>   ERROR: Could not fake-am version v11
>   ---
>   Could not create fake-am range for upper series v11
> 
> Can you fix your process so the tools will be happy? Please read
> carefully your internal guideline go/upstream before posting next
> version.
> 

It may be because, I did not use b4 tool for this.
Will send the next version with b4 tool.




[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux