On 20/03/2025 06:55, Wenbin Yao wrote: > From: Qiang Yu <quic_qianyu@xxxxxxxxxxx> > > Add perst, wake and clkreq sideband signals and required regulators in > PCIe3 controller and PHY device tree node. Describe the voltage rails of > the x8 PCI slots for PCIe3 port. > > Signed-off-by: Qiang Yu <quic_qianyu@xxxxxxxxxxx> > Signed-off-by: Wenbin Yao <quic_wenbyao@xxxxxxxxxxx> > --- > arch/arm64/boot/dts/qcom/x1e80100-qcp.dts | 119 ++++++++++++++++++++++ > 1 file changed, 119 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/x1e80100-qcp.dts b/arch/arm64/boot/dts/qcom/x1e80100-qcp.dts > index 28086a2bc..9cd313802 100644 > --- a/arch/arm64/boot/dts/qcom/x1e80100-qcp.dts > +++ b/arch/arm64/boot/dts/qcom/x1e80100-qcp.dts > @@ -318,6 +318,48 @@ vreg_wcn_3p3: regulator-wcn-3p3 { > regulator-boot-on; > }; > > + vreg_pcie_12v: regulator-pcie_12v { Don't send the downstream code. Underscore are not allowed in node names plus: Please use name for all fixed regulators which matches current format recommendation: 'regulator-[0-9]v[0-9]' https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/devicetree/bindings/regulator/fixed-regulator.yaml?h=v6.11-rc1#n46 Best regards, Krzysztof