On Wed, Mar 19, 2025 at 12:21:25PM +0800, Stone Zhang wrote: > > > On 3/18/2025 11:54 PM, Konrad Dybcio wrote: > > On 3/18/25 10:33 AM, Stone Zhang wrote: > > > Enable WLAN on qcs8300-ride by adding a node for the PMU module > > > of the WCN6855 and assigning its LDO power outputs to the existing > > > WiFi module. > > > > > > Signed-off-by: Stone Zhang <quic_stonez@xxxxxxxxxxx> > > > --- > > > > This change looks good generally, but please align the various stylistic > > things, like property order in the nodes you add with x1e80100-crd.dtsi > > > > I also see that board-2.bin doesn't contain the variant string you've > > suggested ([1] @ commit 646e008ec53a8bb9ae16ebf98a65b29eaefd6da4) > for qcs8300-ride platform, WLAN uses borad-2.bin from link: This phrase doesn't make sense. The board uses nothing. Users / developers build images to be installed on the board. Please use linux-firmware instead of using staging firmware repositories from CLO. This matches expectations of other users. > https://git.codelinaro.org/clo/ath-firmware/ath11k-firmware/-/blob/main/QCA6698AQ/hw2.1/board-2.bin?ref_type=heads Please add a note to the commit message mentioning that the board uses QCA6698AQ instead of WCN6855 (as Konrad and I have thought). Corresponding BDF files were added in 20250211 release. > > > > > Konrad > > > > [1] https://git.codelinaro.org/clo/ath-firmware/ath11k-firmware/-/blob/main/WCN6855/hw2.0/board-2.bin?ref_type=heads > -- With best wishes Dmitry
