On Tue, 2025-03-18 at 10:00 +0100, Krzysztof Kozlowski wrote: > External email : Please do not click links or open attachments until > you have verified the sender or the content. > > > On 18/03/2025 09:32, Jjian Zhou (周建) wrote: > > > > + > > > > + return IPI_ACTION_DONE; > > > > +} > > > > +EXPORT_SYMBOL(mtk_vcp_ipc_send); > > > > > > Drop export - no users > > > > > > Anyway, every export must be GPL. > > > > The Video Companion Processor (VCP) driver (currently being > > prepared > > for submission to the community) will call it. > > > > It does not work like that. You must post the users NOW. > > NAK > Let's review this patch together after the VCP driver is ready. Patch 1 and Patch 3 will be combined into v4 for review. How do you think? > > ... > > > > Check goes immediately after declaration. I doubt it is useful in > > > the > > > first place as this cannot even happen... > > > > > > > > > > + dev_err(dev, "No platform data available\n"); > > > > > > No, drop. Cannot happen or fix your drivers. Who provides the > > > platdata here? > > > > The VCP driver will call platform_device_register_data to register > > the > > structure data. mtk_vcp_ipc_probe will be triggered by vcp_probe. > > This > > structure data is the structure we described in the cover letter. > > > Comment is still valid. Let's review this patch together after the VCP driver is ready. Patch 1 and Patch 3 will be combined into v4 for review. How do you think? > > Best regards, > Krzysztof
