Re: [PATCH 3/3] remoteproc: Use of_reserved_mem_region_* functions for "memory-region"

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On 18/03/2025 00:24, Rob Herring (Arm) wrote:
Use the newly added of_reserved_mem_region_to_resource() and
of_reserved_mem_region_count() functions to handle "memory-region"
properties.

The error handling is a bit different in some cases. Often
"memory-region" is optional, so failed lookup is not an error. But then
an error in of_reserved_mem_lookup() is treated as an error. However,
that distinction is not really important. Either the region is available
and usable or it is not. So now, it is just
of_reserved_mem_region_to_resource() which is checked for an error.

Signed-off-by: Rob Herring (Arm) <robh@xxxxxxxxxx>
---
For v6.16

  drivers/remoteproc/imx_dsp_rproc.c        | 44 ++++++---------
  drivers/remoteproc/imx_rproc.c            | 65 ++++++++-------------
  drivers/remoteproc/qcom_q6v5_adsp.c       | 24 +++-----
  drivers/remoteproc/qcom_q6v5_mss.c        | 60 +++++++-------------
  drivers/remoteproc/qcom_q6v5_pas.c        | 69 ++++++++---------------
  drivers/remoteproc/qcom_q6v5_wcss.c       | 25 ++++----
  drivers/remoteproc/qcom_wcnss.c           | 23 +++-----
  drivers/remoteproc/rcar_rproc.c           | 36 +++++-------
  drivers/remoteproc/st_remoteproc.c        | 39 ++++++-------
  drivers/remoteproc/stm32_rproc.c          | 42 ++++++--------
  drivers/remoteproc/ti_k3_dsp_remoteproc.c | 28 ++++-----
  drivers/remoteproc/ti_k3_m4_remoteproc.c  | 28 ++++-----
  drivers/remoteproc/ti_k3_r5_remoteproc.c  | 28 ++++-----
  drivers/remoteproc/xlnx_r5_remoteproc.c   | 49 ++++++----------
  14 files changed, 213 insertions(+), 347 deletions(-)

<snip>

I get:
ERROR: modpost: "devm_ioremap_resource_wc" [drivers/remoteproc/qcom_q6v5_adsp.ko] undefined!
ERROR: modpost: "devm_ioremap_resource_wc" [drivers/remoteproc/qcom_q6v5_pas.ko] undefined!
ERROR: modpost: "devm_ioremap_resource_wc" [drivers/remoteproc/qcom_wcnss_pil.ko] undefined!
ERROR: modpost: "devm_ioremap_resource_wc" [drivers/remoteproc/ti_k3_dsp_remoteproc.ko] undefined!
ERROR: modpost: "devm_ioremap_resource_wc" [drivers/remoteproc/ti_k3_m4_remoteproc.ko] undefined!
ERROR: modpost: "devm_ioremap_resource_wc" [drivers/remoteproc/ti_k3_r5_remoteproc.ko] undefined!

when building with arm64 defconfig. I guess a proper:
EXPORT_SYMBOL(devm_ioremap_resource_wc)
is missing.

Neil





[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux