Hi John,
On Mon, 17 Mar 2025 at 12:14, John Madieu <john.madieu.xa@xxxxxxxxxxxxxx> wrote:
> > From: Krzysztof Kozlowski <krzk@xxxxxxxxxx>
> > On Sat, Mar 15, 2025 at 09:12:16AM +0100, John Madieu wrote:
> > > Enable the CONFIG_RZG3E_THERMAL flag for the RZ/G3E SoC.
> >
> > s/RZ/Renesas RZ/ and which *upstream* board uses it? This is not your
> > platform defconfig, but all platforms and all users defconfig.
> >
>
> Noted for the fix.
>
> However, most thermal drivers use SOC-specific config options,
> as we can see in arm64 defconfig:
>
> [...]
> CONFIG_IMX8MM_THERMAL=m
> CONFIG_K3_THERMAL=m
> CONFIG_QORIQ_THERMAL=m
> CONFIG_SUN8I_THERMAL=y
> CONFIG_ROCKCHIP_THERMAL=m
> CONFIG_RCAR_THERMAL=y
> CONFIG_RCAR_GEN3_THERMAL=y
> CONFIG_RZG2L_THERMAL=y
> CONFIG_ARMADA_THERMAL=y
> CONFIG_MTK_THERMAL=m
> CONFIG_MTK_LVTS_THERMAL=m
> CONFIG_BCM2711_THERMAL=m
> CONFIG_BCM2835_THERMAL=m
> CONFIG_BRCMSTB_THERMAL=m
> [...]
>
> Hence my choice for RZG3E_THERMAL, or did I miss something in your comment?
I think Krzysztof is complaining about "RZ/G3E SoC" in the patch
description, not about the name of the config symbol (which is fixed).
In addition, he asks for mentioning the board this will be used on.
E.g.:
Enable the Renesas RZ/G3E thermal driver, as used on the Renesas
RZ/G3E SMARC EVK board.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
