On Mon, Mar 17, 2025 at 11:30:16AM +0530, Vikash Garodia wrote: > > On 3/16/2025 12:02 AM, Dmitry Baryshkov wrote: > > On Sat, Mar 15, 2025 at 02:43:30PM +0100, Konrad Dybcio wrote: > >> On 3/11/25 1:03 PM, Vikash Garodia wrote: > >>> Video node enables video on Qualcomm SA8775P platform. > >>> > >>> Signed-off-by: Vikash Garodia <quic_vgarodia@xxxxxxxxxxx> > >>> --- > >>> arch/arm64/boot/dts/qcom/sa8775p.dtsi | 67 +++++++++++++++++++++++++++++++++++ > >>> 1 file changed, 67 insertions(+) > >>> > >> > >>> + <&mmss_noc MASTER_VIDEO_P0 QCOM_ICC_TAG_ALWAYS > >>> + &mc_virt SLAVE_EBI1 QCOM_ICC_TAG_ALWAYS>; > >>> + interconnect-names = "cpu-cfg", > >>> + "video-mem"; > >>> + > >>> + firmware-name = "qcom/vpu/vpu30_p4_s6.mbn"; > > > > Firmware-name should be a part of the board DT file rather than the SoC > > DT. > Given that video ip is independent of any board, remains same for any board > variant of SA8775p, and again for the same reason, PIL, aspects of video driver > was made out of probe, i would prefer to keep it in SOC. Again, this can be > overridden in board specific variant DT, if any case arise, incase. This file is also board-specific and will not be accepted by a board fused to work with a particular set of CA keys. So, no. This needs to go to the board DT file. -- With best wishes Dmitry
