On Fri, Mar 14, 2025 at 08:58:27PM +0100, David Heidelberg wrote: > Convert the Analog Devices ad5820 to DT schema format. > > Add the previously undocumented io-channel-cells property, You did not explain here *why* you added this property. Your patch, your changes, anything should say why you are doing it. > which can be omitted. If present, it must be set to 0, > as the device provides only one channel. Also, Please wrap commit message according to Linux coding style / submission process (neither too early nor over the limit): https://elixir.bootlin.com/linux/v6.4-rc1/source/Documentation/process/submitting-patches.rst#L597 > > Signed-off-by: David Heidelberg <david@xxxxxxx> > --- > Changes in v2: > - added MAINTAINERS entry for the binding > - documented why io-channel-cells got added into the binding. > - dropped io-channel-cells in required properties. > - adjusted example indentation to 4 spaces. > - Link to v1: https://lore.kernel.org/r/20250209203940.159088-1-david@xxxxxxx Best regards, Krzysztof