On Mon, Mar 17, 2025 at 12:14:33PM +0200, Andy Shevchenko wrote: > On Mon, Mar 17, 2025 at 11:08:56AM +0100, Francesco Dolcini wrote: > > On Thu, Mar 13, 2025 at 04:08:14PM +0100, Hans de Goede wrote: > > > On 13-Mar-25 3:43 PM, Francesco Dolcini wrote: ... > > > 1. A drivers/mfd/ MFD driver with the regmap stuff, > > > registering "board-reset" and "gpio" cells > > > > So, we considered the idea of going with an MFD driver, but looking at > > drivers/platform/cznic, that is doing something relatively close to what > > we are doing (just more feature rich, as of now), drivers/platform/ > > seemed a better fit. > > > > I am not 100% sure what's Andy opinion on this topic, from what I can > > understand his concerns are about the toradex directory (that we'll get > > rid of), not the drivers/platform/ parent you are concerned about. > > Yes, my point is to have this inside existing folder whatever you decide > with the maintainers of the respective subsystem to be. But if you have more than one module, it might be still good to have at some level, and drivers/platform might be too low for it (too broad). So, either path/to/foo/toradex.c, or path/to/foo/toradex/*.[ch]. -- With Best Regards, Andy Shevchenko
