On 17/03/2025 09:38, Jjian Zhou wrote: > This patch adds document for mediatek vcp mbox. > > Signed-off-by: Jjian Zhou <jjian.zhou@xxxxxxxxxxxx> > --- > .../bindings/mailbox/mtk,mt8196-vcp-mbox.yaml | 49 +++++++++++++++++++ Please use subject prefixes matching the subsystem. You can get them for example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory your patch is touching. For bindings, the preferred subjects are explained here: https://www.kernel.org/doc/html/latest/devicetree/bindings/submitting-patches.html#i-for-patch-submitters > 1 file changed, 49 insertions(+) > create mode 100644 Documentation/devicetree/bindings/mailbox/mtk,mt8196-vcp-mbox.yaml Filename based on compatible. You already got this comment. Copy paste your filename here: <here goes filename> and here your compatible: <here goes compatible> Are the the same? Best regards, Krzysztof