Re: [PATCH 03/12] clocksource: sti: Provide 'use timer as sched clock' capability

[Paul Bolle <pebolle@xxxxxxxxxx>]

On Fri, 2015-05-08 at 11:29 +0100, Lee Jones wrote:
> Ah, you mean from menuconfig.  I almost forgot what that was. ;)
> 
> I can add a menu option, no problem.

It's not just menuconfig:
    $ grep -e CONFIG_ARCH_STI -e CONFIG_CLKSRC_ST_LPC .config 
    CONFIG_ARCH_STI=y
    CONFIG_CLKSRC_ST_LPC=y
    CONFIG_CLKSRC_ST_LPC_TIMER_SCHED_CLOCK=y
    $ vim .config 
    $ grep -e CONFIG_ARCH_STI -e CONFIG_CLKSRC_ST_LPC .config 
    CONFIG_ARCH_STI=y
    # CONFIG_CLKSRC_ST_LPC is not set
    # CONFIG_CLKSRC_ST_LPC_TIMER_SCHED_CLOCK is not set
    $ make ARCH=arm silentoldconfig
    scripts/kconfig/conf  --silentoldconfig Kconfig
    #
    # configuration written to .config
    #
    $ grep -e CONFIG_ARCH_STI -e CONFIG_CLKSRC_ST_LPC .config 
    CONFIG_ARCH_STI=y
    CONFIG_CLKSRC_ST_LPC=y
    CONFIG_CLKSRC_ST_LPC_TIMER_SCHED_CLOCK=y

So I think that, if you want to be able to set
CLKSRC_ST_LPC_TIMER_SCHED_CLOCK to 'n' even though CLKSRC_ST_LPC is 'y',
you need to add a prompt. Or have you found a way around this?

Thanks,


Paul Bolle

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html