On Fri, Mar 14, 2025 at 01:55:47PM +0100, Krzysztof Kozlowski wrote: > On 14/03/2025 10:42, Ian Ray wrote: > > > > /* Get SNVS register Page */ > > @@ -148,6 +152,24 @@ static int imx_snvs_pwrkey_probe(struct platform_device *pdev) > > if (pdata->irq < 0) > > return -EINVAL; > > > > + if (!of_property_read_u32(np, "power-off-time-sec", &val)) { > > And when you test your DTS against binding what do you see? I suspect > new warning. I checked the build logs (from a clean workarea), plus run-time dmesg, both with the DTS change -- and without it. There are no new warnings (specifically nothing mentioning snvs-pwrkey or dts or power-off-time). If an invalid value (such as "42") is chosen then the probe fails with -EINVAL as expected. Is there something else that I should have checked? > > Best regards, > Krzysztof Blue skies, Ian