On 13/03/2025 09:05, Varadarajan Narayanan wrote: > Append the MHI register range to IPQ9574. This is an optional range used Same question, you still did not answer - does hardware have this range? Which hardware has it? I pointed out that you affect at least two other variants. Your commit msg must explain that. For example what if they do not have this range? Then this change is just wrong. Start documenting the hardware, not your drivers. Best regards, Krzysztof