Hi, > The pinctrl-names should be changed to "default" and not "active", > something you can fixup or do you want a patch? Sorry I've been a bit busy this week and forgot to send the v2 patch. In rk3528.dtsi, the uart and upcoming i2c nodes do not have pinctrl, so I prefer to remove them. >> Unlike other SoCs, pinctrl-names need to be in "active" state, >> I'm not sure about this, but otherwise the pwm-regulator will >> not work properly. BTW, setting the pinctrl of pwm corresponding to pwm-regulator to "default" will cause kernel boot suspended. Sorry but do you know why? e.g. ``` vdd_arm: regulator-vdd-arm { compatible = "pwm-regulator"; pwms = <&pwm1 0 5000 1>; ... }; &pwm1 { pinctrl-0 = <&pwm1m0_pins>; pinctrl-names = "default"; status = "okay"; }; ``` Thanks, Chukun -- 2.25.1